Fix Pixiv label bookmark controls visibility - #44
Open
WeilinChen1221 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the Pixiv Label Bookmarks controls no longer appeared after Pixiv changed its generated DOM class names and navigation layout.
Previously, the userscript depended on unstable Pixiv
sc-*class selectors and attempted to inject the Label/Search controls through Pixiv's navigation area. After Pixiv's UI update, initialization could still continue, but the controls could be hidden, delayed, or blocked by missing DOM nodes.Changes
document.bodyinstead of Pixiv'snav.z-index, so Pixiv or Bootstrap styles do not hide the controls.synonymDict/ tag data during initialization.Testing
Ran:
Result: passed.
Manually verified in the browser that the userscript reaches the expected initialization flow:
InitializedStart InjectingTry InjectingElement Properties SetSynonym Dictionary ReadyAdvanced Search SetWhen Pixiv's work-list container is unavailable, the script may log
Work container unavailable, skipped. This now only disables the optional inline work-tag display and no longer blocks the main floating Label/Search controls.Rollback
Revert this PR to restore the previous nav-injected controls and legacy DOM selector behavior.