Skip to content

ZCS 20105: Added LDAP attributes zimbraSamlSpSigningKey and zimbraSamlSpSigningCertificate - #1862

Open
ashishkhms wants to merge 1 commit into
developfrom
feature/ZCS-20105
Open

ZCS 20105: Added LDAP attributes zimbraSamlSpSigningKey and zimbraSamlSpSigningCertificate#1862
ashishkhms wants to merge 1 commit into
developfrom
feature/ZCS-20105

Conversation

@ashishkhms

Copy link
Copy Markdown
Contributor

Jira link: https://synacor.atlassian.net/browse/ZCS-20105

Adds two new LDAP attributes to zm-mailbox to support SAML SP request signing. These attributes will later be used for signing SP-generated requests (AuthnRequest, LogoutRequest), resolving signed-request issues with certain IdPs that require signed LogoutRequests from the SP.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25333


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25338


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25346


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25346


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25347


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25347


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25348


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25348


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25361


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25361


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25375


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25375


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25377


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25377


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25392


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25392


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25393


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25393


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25394


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25394


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25407


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25407


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25409


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25409


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25423


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25423


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25424


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25424


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25425


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrDomain.java#L25425


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72685


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72692


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72692


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72697


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72705


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72705


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72706


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 134).

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72706


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72707


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72707


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72712


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72721


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72721


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 124).

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72723


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72723


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72728


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72735


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72735


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72737


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72737


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72742


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72750


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72750


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72751


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72751


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72752


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72752


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72765


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72765


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72779


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72779


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72781


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72781


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72796


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72796


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72797


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72797


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72798


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72798


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72811


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72811


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72813


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72813


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72827


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72827


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72828


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72828


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72829


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/769b4d6d7936ea763d891926a504b04832f2818d/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72829

Comment thread common/src/java/com/zimbra/common/account/ZAttrProvisioning.java
Comment thread common/src/java/com/zimbra/common/account/ZAttrProvisioning.java
Comment thread common/src/java/com/zimbra/common/account/ZAttrProvisioning.java
Comment thread common/src/java/com/zimbra/common/account/ZAttrProvisioning.java
Comment thread common/src/java/com/zimbra/common/account/ZAttrProvisioning.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
@ashishkhms

Copy link
Copy Markdown
Contributor Author

Note on Checkstyle Warning: The checkstyle warning reported in this PR is a false positive and does not indicate an actual code style violation. The flagged code follows the existing patterns used across the codebase. This has been reviewed and can be safely ignored.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72685


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72692


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72692


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72697


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72705


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72705


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72706


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 134).

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72706


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72707


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72707


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72712


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72721


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72721


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 124).

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72722


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72723


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72723


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72728


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72735


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72735


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72737


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72737


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72742


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72750


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72750


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72751


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72751


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72752


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72752


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72765


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72765


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72779


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72779


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72781


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72781


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72796


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72796


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72797


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72797


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72798


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72798


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72811


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72811


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72813


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72813


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72827


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72827


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72828


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72828


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72829


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.

https://github.com/Zimbra/zm-mailbox/blob/7713df7ada568b78284c95d920854995bb319029/store/src/java/com/zimbra/cs/account/ZAttrConfig.java#L72829

Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Comment thread store/src/java/com/zimbra/cs/account/ZAttrDomain.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants