ZCS-19152 : Added feature based flag for Native Mobile APP - #1847
ZCS-19152 : Added feature based flag for Native Mobile APP#1847GuruanthDeshmukh wants to merge 1 commit into
Conversation
|
|
| * @since ZCS 10.1.20 | ||
| */ | ||
| @ZAttr(id = 4152) | ||
| public static final String A_zimbraFeatureNativeMobileAppEnabled = "zimbraFeatureNativeMobileAppEnabled"; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.ConstantNameCheck> reported by reviewdog 🐶
Name 'A_zimbraFeatureNativeMobileAppEnabled' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
There was a problem hiding this comment.
Leaving this checkstyle issue as-is for the following reasons:
- This attribute is auto-generated using the
ant generate-ldap-config -Dzimbra.buildinfo.version=<BUILD_VERSION>command. - Updating it to comply with the checkstyle rule would break the homogeneity of attribute constants throughout the file.
f0099f3 to
98285f7
Compare
98285f7 to
c20018d
Compare
c20018d to
df3a24c
Compare
8962f01 to
de163b2
Compare
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 145).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 135).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 145).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 135).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| @ZAttr(id=4032) | ||
| public static final String A_zimbraFeatureModernVideoEnabled = "zimbraFeatureModernVideoEnabled"; | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| return attrs; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| return getBooleanAttr(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, false, true); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) | ||
| public void setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled) throws com.zimbra.common.service.ServiceException { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) | ||
| public void setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled) throws com.zimbra.common.service.ServiceException { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 145).
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
| return attrs; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| */ | ||
| @ZAttr(id=4164) | ||
| public void unsetFeatureNativeMobileAppEnabled() throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 135).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 145).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 135).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4165) | ||
| public void unsetFeatureNativeMobileAppEnabled() throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| getProvisioning().modifyAttrs(this, attrs); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4165) | ||
| public Map<String,Object> unsetFeatureNativeMobileAppEnabled(Map<String,Object> attrs) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4165) | ||
| public Map<String,Object> unsetFeatureNativeMobileAppEnabled(Map<String,Object> attrs) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4165) | ||
| public Map<String,Object> unsetFeatureNativeMobileAppEnabled(Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4165) | ||
| public void setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled) throws com.zimbra.common.service.ServiceException { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 145).
| */ | ||
| @ZAttr(id=4165) | ||
| public void setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled) throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4165) | ||
| public void setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled) throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| @ZAttr(id=4165) | ||
| public void setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled) throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
| @ZAttr(id=4165) | ||
| public void setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled) throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
b5934c9 to
eb3855f
Compare
eb3855f to
0fde745
Compare
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 145).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 135).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
| return attrs; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
0fde745 to
c404806
Compare
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4164) | ||
| public void unsetFeatureNativeMobileAppEnabled() throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4164) | ||
| public void unsetFeatureNativeMobileAppEnabled() throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| getProvisioning().modifyAttrs(this, attrs); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 135).
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
3bbed1f to
eb09f1a
Compare
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
| @ZAttr(id=4164) | ||
| public Map<String,Object> setFeatureNativeMobileAppEnabled(boolean zimbraFeatureNativeMobileAppEnabled, Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); | ||
| attrs.put(Provisioning.A_zimbraFeatureNativeMobileAppEnabled, zimbraFeatureNativeMobileAppEnabled ? TRUE : FALSE); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 122).
| return attrs; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
| * | ||
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> unsetFeatureNativeMobileAppEnabled(Map<String,Object> attrs) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| * @since ZCS 10.1.21 | ||
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> unsetFeatureNativeMobileAppEnabled(Map<String,Object> attrs) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> unsetFeatureNativeMobileAppEnabled(Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
| */ | ||
| @ZAttr(id=4164) | ||
| public Map<String,Object> unsetFeatureNativeMobileAppEnabled(Map<String,Object> attrs) { | ||
| if (attrs == null) attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
eb09f1a to
34a46fb
Compare
34a46fb to
b8221e4
Compare
ZCS-19152 - Changes added for flag based feature enabling/disabling Native Mobile APP