Skip to content

fix: Excalidraw tab state and Vim tab navigation#392

Closed
junereycasuga wants to merge 3 commits into
ZenNotes:mainfrom
junereycasuga:fix/excalidraw-viewport-restore
Closed

fix: Excalidraw tab state and Vim tab navigation#392
junereycasuga wants to merge 3 commits into
ZenNotes:mainfrom
junereycasuga:fix/excalidraw-viewport-restore

Conversation

@junereycasuga

Copy link
Copy Markdown
Contributor

This fixes a few issues when switching to/from Excalidraw tabs:

  • Excalidraw viewport state was not preserved when returning to a drawing.
  • Note scroll position could reset after switching away to Excalidraw.
  • gt/gT did not work reliably while focused in Excalidraw.
  • After navigating from Excalidraw to a note, focus could remain outside the editor.

The fix preserves Excalidraw viewport state, snapshots note scroll before the editor is torn down, handles Vim tab navigation from Excalidraw, and restores editor focus when landing on a normal note.


Before:

Cap.2026-07-14.at.20.53.35.mp4

After:

Cap.2026-07-14.at.20.55.02.mp4

@junereycasuga
junereycasuga requested a review from adibhanna as a code owner July 14, 2026 14:41
@adibhanna

Copy link
Copy Markdown
Contributor

Thanks for this, @junereycasuga, really clean fix!

I've cherry-picked all three commits onto the v2.13.2 release branch (your authorship is preserved), so it ships in 2.13.2 rather than landing on main first.

Verified end to end: gt/gT now cycle tabs even from a focused Excalidraw drawing, focus returns to the editor after the jump, and switching to and from a drawing keeps its pan/zoom and the note's scroll position. Build and tests pass on all platforms.

Since it was cherry-picked (different commit SHAs), GitHub won't auto-close this, so I'm closing it manually. Thanks again for contributing!

@adibhanna adibhanna closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants