fix: space leader-key conflict in Excalidraw tabs (#309)#310
Closed
junereycasuga wants to merge 1 commit into
Closed
fix: space leader-key conflict in Excalidraw tabs (#309)#310junereycasuga wants to merge 1 commit into
junereycasuga wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing after commit 2b21343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Space leader-key conflict in Excalidraw tabs (#309)
When Space is configured as the Vim leader key, ZenNotes currently consumes Space before Excalidraw can use it for its temporary hand/pan mode. This makes it impossible to hold Space and drag around the canvas.
This PR keeps the existing short-press Space leader behavior, while allowing a long Space press inside Excalidraw to pass through to Excalidraw for canvas panning.
Changes:
Before:

After:
