ci(nix): validate the prebuilt desktop package (ldd, interpreter, smoke launch)#212
Merged
Conversation
Splits the build into per-package out-links and adds a validation step that proves the wrapped binary is actually runnable: ELF interpreter patched into the Nix store, ldd resolves every shared library, wrapper/desktop-entry/icons installed, and the SUID chrome-sandbox removed. Plus a best-effort headless xvfb smoke-launch (non-blocking) to confirm Electron starts without a loader crash. Also adds this workflow's own path to the triggers so workflow edits are exercised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #211. Proves the prebuilt
zennotes-desktopis runnable, not just buildable:ZenNotesbinary is patched into the Nix storelddresolves every shared library (no=> not found)chrome-sandboxremovedThis is the closest we can get to runtime validation without a NixOS box — the
Nix buildcheck on this PR runs all of it.