Conversation
convertResponse/emitCompleted echoed request-scoped fields with ?? null
fallbacks, so when the request omitted them the response reported null
where the legacy toOpenAIRespResponse applied API defaults
(temperature=1, top_p=1, truncation="disabled", text.verbosity="medium",
service_tier="default", background=false). It also omitted
conversation/prompt/user/safety_identifier/prompt_cache_retention that
legacy always emitted.
Match the legacy fallback map in echoRequestFields and the response
return: temperature??1, top_p??1, truncation??"disabled",
text ?? {format:{type:text},verbosity:medium}, service_tier from response
or "default", background??false, plus conversation:null, prompt:null,
user:null, safety_identifier:null, prompt_cache_retention:null.
Bump to 1.0.8. All 552 tests pass.
…pId>) rosetta generated output-item ids as <prefix>_<random> (e.g. rs_o7o7rz4pwjf), where the legacy converter used <prefix>_<choice.index>_<response.id> (e.g. rs_0_chatcmpl-123). Align non-stream convertResponse and the streaming convertStreamChunk/openMessage sites to the legacy format using the CC response id and choice index. Remove the now-unused generateId(). Bump to 1.0.9. All 552 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converters Affected
Changes
Verification
npm run typecheckpassesnpm run lintpassesnpm testpassesnpm run buildsucceeds