Repository navigation
ci: gate release tags on complete candidate validation - #25
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The v1.2.5 release failed because
release-on-mergepushed the version commit and immutable tag before dispatchingRelease Build. PR validation ran against v1.2.4, so the hardcoded v1.2.4 fixture passed there; the later tag validation ran against v1.2.5 and failed. The tag therefore existed even though no GitHub Release was published.This makes the release flow synchronous and gates the source commit/tag on the actual candidate:
Verification
actionlint .github/workflows/*.ymlnode --test tests/release-integrity.test.mjs(8 passing)pnpm test(121 passing)pnpm typecheckpnpm build