Added ability to specify allowed extensions for attachments. - #302
Open
bellingeri wants to merge 1 commit into
Open
Added ability to specify allowed extensions for attachments.#302bellingeri wants to merge 1 commit into
bellingeri wants to merge 1 commit into
Conversation
The default setting is set on first launch. It can be changed in the settings.
Zavy86
requested changes
Jul 13, 2026
Zavy86
left a comment
Owner
There was a problem hiding this comment.
What happens when the update occurs until the new settings are available? Does it load an empty array or does it fail? (I haven't been able to test this yet; you might already know.)
Author
|
Good question! |
Author
|
Hi. Something like this: update.php Let me know... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I've added the ability to define which extensions are accepted in attachments.
The default setting is set upon initial startup [setup.php] without prompting the user (to keep the installation streamlined) and can then be changed in [settings.php].
Previously, the accepted files were statically listed in the code (perhaps with some differences between the various files).
I had to comment out the mime/type verification section: I find it complex to ask the user to enter them.
Someone could instead provide a list of "extensions" to "mime/types" and check using that.
Comments are welcome!
I've also prepared translations for the added strings, but with automatic translators... not the best.