Repository navigation
Repair workbook-state integration and scoped search regression (#662) - #1
Open
scottcampbelldata wants to merge 2 commits into
Open
scottcampbelldata wants to merge 2 commits into
scottcampbelldata wants to merge 2 commits into
Conversation
Zarvinx
force-pushed
the
egui-workbook-state
branch
from
October 13, 2026 23:41
307cb7c to
f79bf61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs current-main integration of workbook-specific egui state in storytold#662. Dialog/pane conflicts retain main's translated titles, pivot labels and pane-width limit together with the author's scoped widget IDs. The incoming Alt+Down keyboard regression now queries the workbook-scoped filter-search ID rather than the obsolete global ID; its assertions for typed search text, unchanged header/workbook and keyboard behavior remain intact.
This integrates original head
307cb7c87c419a9b4b3b04ea13d7502bdd0f0b15with main84acf6293b1dc1fc09837524e035d674eb4d6741. All eightcargo xtask cigates passed on Ubuntu 24.04 / Rust 1.99.0 after the test adaptation, including native UI regressions, strict Clippy and wasm compilation. Exact source tree1f2339f2976483ec127bd4a0fbb3b0c9f20dc923matched the validation checkout; both remained unchanged.The French UI with the Comments pane was rendered and reviewed from that same tested tree in the dedicated validation checkout under the shared cache lock, with unchanged source and validation trees. This checks the integration and offscreen layout, without claiming every physical desktop/platform interaction verified. The initial failing snapshot is not cited as pass evidence.