Repository navigation
gpu_unlock: detect aperture API by header presence - #289
Open
lslowmotion wants to merge 1 commit into
Open
lslowmotion wants to merge 1 commit into
lslowmotion wants to merge 1 commit into
Conversation
RHEL 9.7 backports the 6.0 aperture helpers into its 5.14-based kernel, so include/linux/aperture.h exists and remove_conflicting_pci_framebuffers() is gone, yet LINUX_VERSION_CODE still reports 5.14.0. The old version check therefore selected the removed function, breaking the DKMS build with an implicit-declaration error. Detect the new API with __has_include(<linux/aperture.h>) instead, which works for both upstream >= 6.0 and RHEL backports regardless of the reported kernel version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RHEL 9.7 backports the 6.0 aperture helpers into its 5.14-based kernel, so include/linux/aperture.h exists and remove_conflicting_pci_framebuffers() is gone, yet LINUX_VERSION_CODE still reports 5.14.0. The old version check therefore selected the removed function, breaking the DKMS build with an implicit-declaration error.
Detect the new API with __has_include(<linux/aperture.h>) instead, which works for both upstream >= 6.0 and RHEL backports regardless of the reported kernel version.