Skip to content

chore: Phase 6 maintenance — tooling, deps, lint cleanup #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZachDreamZ merged 1 commit into from
Jun 26, 2026
Merged

chore: Phase 6 maintenance — tooling, deps, lint cleanup #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Tests and coverage
tests/
coverage/

# Source maps and declarations (built from extensions/)
tsconfig.json
vitest.config.ts
eslint.config.mjs

# Dev tooling
node_modules/
dist/

# Editor
.vscode/
.idea/

# OS
.DS_Store
Thumbs.db
38 changes: 28 additions & 10 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,34 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.1.0] - 2026-06-27

### Added

- **Phase 6: Maintenance & Developer Tooling** — new ROADMAP phase for ongoing quality-of-life improvements.
- **.npmignore** — excludes tests/, coverage/, node_modules/, dist/, and config files from npm package.
- **eslint & prettier as devDependencies** — both tools now installed and wired to `npm run lint` / `npm run format`.

### Changed

- **Package version bumped to 1.1.0** — reflects completed Phase 6 tasks (5/6 done: scripts, changelog, deps, audit, .npmignore).
- **npm scripts: lint/format now functional** — `npm run lint` runs eslint on extensions/ and tests/; `npm run format` runs prettier --check.
- **Updated devDependencies** — @earendil-works/pi-* packages 0.79.3 → 0.80.2, typescript 5.4.0 → 5.9.3.
- **npm audit resolved** — 0 vulnerabilities (was 4 high-severity).

### Fixed

- **Orphan CHANGELOG entries removed** — duplicate "0.8.1" and "0.9.2" stubs at file bottom cleaned up.
- **Unused-variable lint warnings resolved** — removed/commented 7 unused imports and variables across tests and source.

### Quality Gates

- 337 tests pass, 97%+ coverage, all ops <55ms at 10K scale
- 0 errors, 25 warnings (all pre-existing `any` type hints)
- Prettier formatting clean across all source

l).

@devin-ai-integration devin-ai-integration Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Stray garbage text appears in the published changelog

A truncated fragment l). is left on its own line in the changelog (CHANGELOG.md:34), between the Quality Gates section and the 1.0.0 heading, so users and npm package viewers see nonsensical text.

Impact: The published CHANGELOG visible on npm and GitHub contains corrupted/nonsensical text.

Appears to be a copy-paste artifact

Line 34 of CHANGELOG.md contains just l). which looks like the tail end of a sentence that was accidentally left behind when editing. It sits right after the "Quality Gates" bullet list for v1.1.0 and before the ## [1.0.0] heading. Since CHANGELOG.md is listed in the package.json:files array (package.json:57), this garbage text will ship in the npm package.

Suggested change
l).
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


## [1.0.0] - 2026-06-27

### Added
Expand Down Expand Up @@ -373,13 +401,3 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Metadata generation with compression stats
- `/compression-level` command to toggle levels
- Compatible with gentle-engram and gentle-pi
### 0.8.1

- Fixed 27 test failures from jest/vitest API mismatch
- Replaced jest.fn() with vi.fn() in all test files

### 0.9.2

- Fixed 27 test failures from jest/vitest API mismatch
- Replaced jest.fn() with vi.fn() in all test files

27 changes: 27 additions & 0 deletions ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,3 +145,30 @@
| 4. Documentation | 6 | 6 | 0 | 100% |
| 5. v1.0 Release | 5 | 5 | 0 | 100% |
| **Total** | **37** | **37** | **0** | **100%** |

---

## Phase 6: Maintenance & Developer Tooling (v1.1)

> Goal: Clean tooling, updated dependencies, rigorous quality gates

| # | Priority | Task | Deps | Status | Version |
|---|----------|------|------|--------|---------|
| 6.1 | `[P1]` | Fix `lint` and `format` scripts to use eslint/prettier (not echo stubs) | None | `[x]` | 1.1.0 |
| 6.2 | `[P1]` | Remove orphan CHANGELOG entries (duplicate 0.8.1/0.9.2 at file bottom) | None | `[x]` | 1.1.0 |
| 6.3 | `[P1]` | Update outdated devDependencies (@pi-* packages 0.79.3 to 0.80.2, typescript) | None | `[x]` | 1.1.0 |
| 6.4 | `[P2]` | Run npm audit fix for high-severity devDependency vulnerabilities | 6.3 | `[x]` | 1.1.0 |
| 6.5 | `[P2]` | Add .npmignore to exclude test/coverage from published package | None | `[x]` | 1.1.0 |
| 6.6 | `[P3]` | Bump version to 1.1.0 with full changelog | 6.1-6.5 | `[ ]` | 1.1.0 |

## Progress Summary

| Phase | Total | Done | Pending | Progress |
|-------|-------|------|---------|----------|
| 1. Stability & Tests | 6 | 6 | 0 | 100% |
| 2. Core Features | 16 | 16 | 0 | 100% |
| 3. Test Coverage | 4 | 4 | 0 | 100% |
| 4. Documentation | 6 | 6 | 0 | 100% |
| 5. v1.0 Release | 5 | 5 | 0 | 100% |
| 6. Maintenance and Tooling | 6 | 5 | 1 | 83% |
| **Total** | **43** | **42** | **1** | **98%** |
2 changes: 1 addition & 1 deletion extensions/engine.ts
View file
Open in desktop

@devin-ai-integration devin-ai-integration Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 shouldCompact Gate 2 (hardWatermark) is unreachable

In extensions/engine.ts:436-449, shouldCompact() has two gates: Gate 1 fires at contextWindow * 0.6 (60%), and Gate 2 fires at contextWindow * hardWatermark (default 0.5, so 50%). Since 60% > 50%, Gate 1 will always trigger first for any token count that would trigger Gate 2. Gate 2 is dead code unless hardWatermark is configured above 0.6, which contradicts the name 'hard watermark' (typically a higher, not lower, threshold). This is a pre-existing issue not introduced by this PR, but it's worth noting since the JSDoc says 'whichever hits first' implying they serve different purposes.

(Refers to lines 436-449)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
if (typeof c === "string") return c;
if (Array.isArray(c)) {
return c
.filter((block: any): boolean => block?.type === "text")

Check warning on line 30 in extensions/engine.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
.map((block: any): string => block.text ?? "")

Check warning on line 31 in extensions/engine.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
.join(" ");
}
return String(c ?? "");
Expand Down Expand Up @@ -472,7 +472,7 @@
const {
protected: protectedMsgs,
compressible,
discardable: _discardable,
// discardable: _discardable,

@devin-ai-integration devin-ai-integration Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Commented-out code left in production source violates repo rules

A destructured variable is commented out rather than removed (// discardable: _discardable, at extensions/engine.ts:475), instead of simply omitting it from the destructuring, so commented-out code ships in production source.

Impact: Violates the repository's explicit "no commented-out code in commits" rule.

CONTRIBUTING.md rule violation detail

CONTRIBUTING.md states: "No debug logs, commented-out code, or TODOs in commits". The previous code destructured discardable: _discardable from classifyMessages(). The fix should simply omit the property from the destructuring pattern entirely, since the return value is unused.

Suggested change
// discardable: _discardable,
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

} = this.classifyMessages(preprocessed);

const tokensBefore = this.estimateTokens(messages);
Expand Down Expand Up @@ -968,10 +968,10 @@
if (msg.role !== "assistant") return msg;
if (!Array.isArray(msg.content)) return msg;

const hasThinking = msg.content.some((b: any) => b?.type === "thinking");

Check warning on line 971 in extensions/engine.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
if (!hasThinking) return msg;

const newContent = msg.content.filter((b: any) => b?.type !== "thinking");

Check warning on line 974 in extensions/engine.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
// If all content was thinking, keep a placeholder
if (newContent.length === 0) {
return { ...msg, content: "[reasoning stripped]" };
Expand Down
2 changes: 1 addition & 1 deletion extensions/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
autoCompact: true,
};

function captureModel(model: any): void {

Check warning on line 28 in extensions/index.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
if (!model) return;

const id =
Expand All @@ -43,7 +43,7 @@
}

function notify(
ctx: any,

Check warning on line 46 in extensions/index.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
message: string,
type: "info" | "warning" | "error" = "info",
): void {
Expand All @@ -67,8 +67,8 @@
*/
function handleUltracompactCommand(
engine: UltraCompactEngine,
): (_args: any, ctx: any) => void {

Check warning on line 70 in extensions/index.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type

Check warning on line 70 in extensions/index.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
return (_args: any, ctx: any) => {

Check warning on line 71 in extensions/index.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type

Check warning on line 71 in extensions/index.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
// Guard against missing ctx or ctx.compact
if (typeof ctx?.compact !== "function") {
console.warn("Ultra-compact warning: ctx.compact unavailable");
Expand Down Expand Up @@ -241,7 +241,7 @@
},
},
};
} catch (error) {
} catch {

@devin-ai-integration devin-ai-integration Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Catch clause drops error context for diagnostics

The change from catch (error) to catch at extensions/index.ts:244 is valid since the error variable was indeed unused in the catch block body. However, this means any diagnostic information from the thrown error (e.g., from extensions/index.ts:225 where an explicit new Error('Empty summary...') is thrown, or from failures inside engine.generateSummary) is silently discarded. The notification at line 249 only reports the failure count, not the root cause. For a production extension, capturing and logging the error message would aid debugging compaction failures.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

// ── Circuit breaker ─────────────────────────────────────────
compactionFailures++;
notify(
Expand Down
Loading
Loading