perf(canvas): reduce interaction latency - #203
Draft
d8dzmf5mfn wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Live gestures could mutate document geometry after the scene cache revision was captured, leaving the rendered scene one or more frames behind the document. Drag/drop also cloned and re-walked the full scene and rendered expensive effects on every pointer frame.
Impact
Canvas manipulation stays attached to the pointer, while manual shape placement avoids the previous main-thread stalls on larger documents.
Validation
cargo test -p op-host-native --features gl-host --lib— 667 passedcargo clippy -p op-host-native --lib -- -D warnings -A clippy::unnecessary_min_or_max -A clippy::collapsible_matchcargo fmt --all -- --checkgit diff --cached --checkNote
The repository-wide pre-commit Clippy gate currently stops on the pre-existing
stop_count.max(0)warning incrates/op-editor-ui/src/widgets/property_panel_layout.rs:82, unchanged fromupstream/main. The affected crate and complete interaction test suite pass as listed above.