feat(cli): add omp install target for skill installer - #190
Open
bnivanov wants to merge 1 commit into
Open
Conversation
Adds `omp` (Oh My Pi agent CLI) as a supported `op install --target` value, with `oh-my-pi` alias. Detection probes both the `omp` binary on PATH and the ~/.omp config directory. Install stages the bundle under ~/.omp/openpencil-skill and links ~/.omp/agent/skills/openpencil-skill (symlink, copy fallback) — the dedicated path keeps ownership clean vs the codex target's shared ~/.agents/skills entry. The discovery entry is recreated each install so a stale file/symlink can't shadow a fresh bundle; uninstall removes both paths. Tests: parse/key unit test (incl. alias) and an integration test covering stale-entry replacement, idempotent install, SKILL.md reachability under ~/.omp/agent/skills, and full uninstall cleanup.
Contributor
|
Thanks for the contribution! Could you please sync your branch with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
omp(the Oh My Pi agent CLI) as a fifthop install --targetvaluealongside
claude,codex,cursor, andopencode, withoh-my-pias an alias.Why
omp discovers user skills from
~/.omp/agent/skills. Today omp users have toplace the skill bundle manually; a first-class target makes
op installwork out of the box and lets bare
op installauto-detect omp (via theompbinary on PATH or an existing
~/.ompdirectory).How
Target::Omp+ parse (omp,oh-my-pi) + key + detection.~/.omp/openpencil-skill, then link~/.omp/agent/skills/openpencil-skill→
bundle/skills(copy fallback via the existinglink_or_copy_dir).file, or outdated copy can't shadow the fresh bundle (same rationale as the
opencode target).
~/.agents/skills(which omp also scans):that path is shared with the codex target and would make uninstall ownership
ambiguous.
Tests
omp_is_an_install_target(parse, key, alias).install_omp_writes_agent_skills_dir_and_uninstall_removes_it— stale-entry replacement, idempotent install,
SKILL.mdreachable underthe scanned skills dir, uninstall removes both paths.
cargo test -p op-cli108/108 pass;cargo clippy -p op-cli --all-targets -- -D warningsclean;cargo fmt -p op-cliapplied.