Conversation
nodchip
reviewed
Jun 23, 2026
|
|
||
| | 手法 | Time | Space | 重複排除 | | ||
| |------|------|-------|--------| | ||
| | ハッシュマップ法 | O(n²) | O(n) | タプルを `seen` セットに追加 | |
There was a problem hiding this comment.
ハッシュマップ法、ハッシュセット法という言い方はあまりしないように思います。
| rest = two_sum_from(i + 1, -nums[i]) | ||
| for pair in rest: | ||
| pair.append(nums[i]) | ||
| result.append(pair) |
There was a problem hiding this comment.
two_sum_from() の中で list を毎回構築しているのがやや無駄に感じました。 nums[i] も two_sum_from() に渡し、直接 result に入れたほうが軽くなると思いました。ただ、定数倍の差しかなく、定数倍の差を気にするのであれば、速い言語で書き直したほうが良さそうだとも思いました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解く問題
3sum
次に解く問題