Guard COM teardown and de-duplicate native test helpers#15
Merged
Yuri05 merged 1 commit intoJun 30, 2026
Merged
Conversation
Copilot created this pull request from a session on behalf of
Yuri05
June 30, 2026 19:37
View session
Yuri05
changed the base branch from
add_C++-tests_from_old_C++_CLI-tests
to
master
June 30, 2026 19:38
Yuri05
marked this pull request as ready for review
June 30, 2026 19:38
Yuri05
changed the base branch from
master
to
add_C++-tests_from_old_C++_CLI-tests
June 30, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies three review findings in the SimModelNative Google Test suite and applies minimal, test-only fixes. All three were still valid.
COM apartment teardown (
TestEnvironment.cpp)ComEnvironmentcalledCoUninitialize()unconditionally, tearing down the apartment even whenCoInitializefailed (e.g.RPC_E_CHANGED_MODE).SetUp()now records success;TearDown()only uninitializes when initialization actually succeeded.Duplicated test data (
RcmSpecs.cpp)should_return_valid_permutation_for_ten_node_examplerebuilt the 10×10 adjacency matrix inline; it now reuses the existingcreateTenNodeMatrix()helper.Duplicated extender class (
TableFormula*Specs.cpp)ValuePoints()/CallCacheValues()wrapper was redefined in three spec files (TableFormulaExtender,TableFormulaForOffsetExtender,TableFormulaForXArgumentExtender).src/TableFormulaTestExtender.h(TableFormulaTestExtender), now included by all three specs and registered in the.vcxproj. The CMake build resolves it via relative include.Notes