Conversation
fflorent
reviewed
Oct 28, 2025
fflorent
left a comment
fflorent
left a comment
Contributor
There was a problem hiding this comment.
Sounds very interesting!
Some real nitpicks (that may be discarded) for now and from my side. I will be interesting in giving a try and see whether the documentation helps me with setting up a debugging environment (though I will probably use nvim-dap instead of vimperator).
| done | ||
| } | ||
| function run_debug() { | ||
| if ! dpkg -l |grep python3-debugpy > /dev/null |
Contributor
There was a problem hiding this comment.
Suggested change
| if ! dpkg -l |grep python3-debugpy > /dev/null | |
| if ! dpkg -l | grep -q python3-debugpy |
| then | ||
| apt install -y python3-debugpy | ||
| fi | ||
| yunohost firewall allow Both 5678 -4 > /dev/null 2> /dev/null |
Contributor
There was a problem hiding this comment.
Suggested change
| yunohost firewall allow Both 5678 -4 > /dev/null 2> /dev/null | |
| yunohost firewall allow Both 5678 -4 &> /dev/null |
BTW, what are the reasons for also hiding errors?
| dev|--dev) dev "${ARGUMENTS[@]}" ;; | ||
| lint|--lint) run_linters "${ARGUMENTS[@]}" ;; | ||
| test|--test) run_tests "${ARGUMENTS[@]}" ;; | ||
| debug|--debug) run_debug "${ARGUMENTS[@]}" ;; |
Contributor
There was a problem hiding this comment.
Suggested change
| debug|--debug) run_debug "${ARGUMENTS[@]}" ;; | |
| debug|--debug) run_debug "${ARGUMENTS[@]}" ;; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted some graphical debugger to avoid pdb nightmare...