Add a new setting to redirect unknown URLs to either the SSO portal or a 404 page#212
Open
Salamandar wants to merge 1 commit into
Open
Add a new setting to redirect unknown URLs to either the SSO portal or a 404 page#212Salamandar wants to merge 1 commit into
Salamandar wants to merge 1 commit into
Conversation
Salamandar
force-pushed
the
portal_404
branch
5 times, most recently
from
32bc4c6 to
22ec0c2
Compare
alexAubin
reviewed
Mar 10, 2023
| --- | ||
| --- 5. REDIRECT TO 404 PAGE IF UNKNOWN URL -> PORTAL IS DISABLED | ||
| --- | ||
| if not conf["err404_to_portal"] and longest_url_match == "" then |
Member
There was a problem hiding this comment.
Ah that's interesting because URL which do match a permission in the SSOwat conf will still redirect to the portal
Dunno if that was the intent but to me that's indeed the behavior we want ;)
Author
There was a problem hiding this comment.
Hmmmm.
Yeah, I think that is. Although… That could very well be configurable too. Do you want the public to know you have a mydomain.tld/very_secret_app_with_a_well_known_name_in_the_url ?
For now, an existing app and a non-existing one will have the same behaviour. Maybe some people will want to keep that.
There would be 2 settings :
- Redirect unknown urls to 404 -> default should be true
- Redirect known URLs to 404 instead of login page -> default should be false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My company would like to disable the automatic "unknown url -> SSO portal" redirection. We would prefer a standard 404 web page.
/!\ UNTESTED /!\