add allow_email parameter - #233
Open
lapineige wants to merge 1 commit into
Open
Conversation
Member
Author
|
!testme |
Contributor
|
Fingers crossed! |
Contributor
Member
Author
|
It's needed for some extensions that send email, so let's keep it ? |
Contributor
|
To me that just gives the false impression that the app integrates properly with email, which it doesnt if this ain't actually used ... Or if we can't configure it automatically, we should at least properly document it how to manually configure it in ADMIN.md maybe ... |
Member
Author
Well then this is the TODO here 🙂 |
Member
|
the password generated for the mail must be displayed somehow... |
Member
Author
In ADMIN.md maybe ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's needed for signed emails.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)