Don't use NodeJS, no clue what's it doing here 🤷

[orhtej2]

Problem

• Monica is a PHP app that utilizes no NodeJS

Solution

• And how do you fix that problem

PR Status

• Code finished and ready to be reviewed/tested
• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[ericgaspar]

!testme

[yunohost-bot]

🚀

[orhtej2]

We need to update the install process for this to work as NodeJS is in fact used in the current setup.

[orhtej2]

!changelog

[orhtej2]

!changelog

[Thovi98]

Mmh yarn is needed, so does Nodejs, no?
Or yarn is not needed at all and those section should be reworked

monica_ynh/scripts/install

Line 62 in e4255fb

pushd "$install_dir"

?

[orhtej2]

@Thovi98 likely yes, I don't remember the details.

It should fetch prebuilts but yarn is doing some additional work IIRC

[orhtej2]

!testme

[yunohost-bot]

🎠

[orhtej2]

!testme

[yunohost-bot]

Alrighty!

[Thovi98]

backup size is 130M insteand of 1,1G -> perfect!

[orhtej2]

I think Monica at some point started shipping prebuilts, the thing seems to be working just fine in my local install 🤷

[orhtej2]

This still requires fixing upgrade for previous versions

[orhtej2]

!testme

[yunohost-bot]

Meow 🐈

[orhtej2]

!testme

[yunohost-bot]

Fingers crossed!

[orhtej2]

Upgrade still yields http/500

[Thovi98]

!testme

[yunohost-bot]

😜

[orhtej2]

There's no progress here, upgrade is KO