Only display the public key when the repo is remote via SSH - #207
Open
olberger wants to merge 11 commits into
Open
Only display the public key when the repo is remote via SSH#207olberger wants to merge 11 commits into
olberger wants to merge 11 commits into
Conversation
fflorent
requested changes
Sep 13, 2025
fflorent
left a comment
fflorent
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! The intent makes sense.
I think it could be worth to rather use visible prop in config panel:
https://doc.yunohost.org/packaging/advanced/config_panels#visible--enabled-expression-evaluation
Which can be used using match().
If I am correct, it should be simpler, and should simply hide the prompt (which is simply useless).
Regarding the get__ssh_public_key() function, I have added the echo "N/A", which assumes probably too quickly that the missing key suggests that the repository is just a local one. Probably this could be removed.
fflorent
force-pushed
the
testing
branch
2 times, most recently
from
October 9, 2025 20:35
b613794 to
23a9b38
Compare
--------- Co-authored-by: Yunohost-Bot <> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: Salamandar <6552989+Salamandar@users.noreply.github.com> Co-authored-by: Olivier Berger <oberger@ouvaton.org> Co-authored-by: Alexandre Aubin <4533074+alexAubin@users.noreply.github.com> Co-authored-by: Florent <florent.git@zeteo.me> Co-authored-by: Kay0u <pierre@kayou.io> Co-authored-by: Grena <grena@grenabox.fr> Co-authored-by: JocelynDelalande <JocelynDelalande@users.noreply.github.com> Co-authored-by: Eauchat <34686393+eauchat@users.noreply.github.com> Co-authored-by: Olivier Berger <olivier.berger@telecom-sudparis.eu> Co-authored-by: shukon <shukon@users.noreply.github.com> Co-authored-by: ljf (zamentur) <zamentur@users.noreply.github.com> Co-authored-by: Robles Rodolphe <rodolphe.robles@sfr.fr>
According to the documentation: > BORG_FILES_CACHE_SUFFIX > When set to a value at least one character long, instructs borg to use a specifically named (based on the suffix) alternative files cache. This can be used to avoid loading and saving cache entries for backup sources other than the current sources. Also it is expected that it would speed up borg when many apps are installed (and this would be an alternate fix for YunoHost-Apps#135)
Add custom YAML formatting for systemd timer patterns.
fflorent
force-pushed
the
testing
branch
3 times, most recently
from
October 25, 2025 08:19
12f0171 to
c9ba55a
Compare
fflorent
force-pushed
the
testing
branch
2 times, most recently
from
August 14, 2026 08:26
21174e9 to
5470ffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a repository is local, the public key setting is displayed nevertheless
PR Status