Repository navigation
feat: support for custom message generation in ZddMessageConfigInterface - #44
Merged
Merged
Conversation
B-Galati
requested review from
Inkod,
TBoileau,
alxvgt,
ismail1432 and
micoli
November 21, 2025 13:56
B-Galati
force-pushed
the
custom-object
branch
from
November 21, 2025 13:58
d9d36aa to
4701ae2
Compare
ismail1432
reviewed
Nov 21, 2025
ismail1432
reviewed
Nov 21, 2025
Collaborator
|
Where Am I? 😭 
|
Contributor
Author
@ismail1432 You already did the review, that's why you are not listed anymore 👍 |
B-Galati
force-pushed
the
custom-object
branch
from
November 21, 2025 16:19
4701ae2 to
7e6d88e
Compare
B-Galati
force-pushed
the
custom-object
branch
3 times, most recently
from
November 24, 2025 13:00
704d9d4 to
cd5a217
Compare
Contributor
Author
|
I just pushed some new changes that introduces the class I did it for 2 main reasons:
|
B-Galati
force-pushed
the
custom-object
branch
from
November 24, 2025 13:41
cd5a217 to
32a634f
Compare
B-Galati
commented
Nov 27, 2025
This refacto will clearly split responsibilities between these 2 concerns. Moreover, it will enable the introduction of the custom message feature to handle edge cases.
B-Galati
force-pushed
the
custom-object
branch
from
December 19, 2025 09:45
692fe04 to
1cb1b99
Compare
TBoileau
reviewed
Dec 19, 2025
B-Galati
changed the title
ZddMessageConfigInterface
…eratorInterface`
B-Galati
force-pushed
the
custom-object
branch
from
December 19, 2025 13:22
49b6619 to
912a5ff
Compare
Contributor
Author
|
The new interface is marked as experimental after discussion with @Inkod. And we also added some warning about nullable cases that can hide ZDD problems for custom messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces optional custom message generation through a new
CustomMessageGeneratorInterface,allowing users to have full control over how specific message instances are created.
Changes
CustomMessageGeneratorInterfacewithgenerateCustomMessage()methodMessageGeneratorclass to centralize message creation logicZddMessageFactoryto delegate message generation toMessageGeneratorNotes
CustomMessageGeneratorInterfaceis optional and separate fromZddMessageConfigInterfacemessages require specific constructor logic