fix(footer): credit contrast, alignment, order, and backdrop - #6
Merged
Merged
Conversation
- Reorder authors: younesfdj first, then Mawsis. - Add a soft dark fade behind the credit so it stays legible over the contribution-grid motif (blurred, soft-edged, no hard pill outline). - Raise contrast: names render in ink-dim, supporting text in ink-soft. - Fix icon/text alignment: nudge the X, heart, and star glyphs onto the text's optical center (relative top-px) and grow them to match x-height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up polish to the footer author credit (PR #5 merged before this commit landed, so these fixes never reached
master).text-ink-dim, supporting text intext-ink-soft.relative top-px) and grow them to match the font's x-height.Changes
components/FooterCredit.tsx— the only file touched.Test plan
tsc --noEmit— 0 errorsnpm run lint(component) — 0 errors