Fix: GitHub token failover - #119
Open
LindonAliu wants to merge 2 commits into
Open
Conversation
|
Merge it please 😭 |
Author
|
Hey @Younesfdj, can you review this PR please ? Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where profiles assigned to an invalid or expired GitHub token would fail immediately with:
GitHub token is invalid or expired.GitFut already supports a pool of GitHub tokens and retries with a fallback token when the assigned token is rate-limited. However, a
401response is classified as aconfigerror, so no fallback was attempted even when other healthy tokens were available.This change:
401failover caseThis prevents a single expired token in
GITHUB_TOKENSfrom breaking scouting for every username hashed to that token.