fix: normalize nil context in UpdateTask - #104
Merged
Merged
Conversation
Owner
|
@Bury-Lee pls check |
Collaborator
OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateTasktocontext.Background().Submit(UpdateTask(nil, task))executes the task.Problem
SubmitCtx(nil, task)already treats a nil context ascontext.Background(). However,UpdateTask(nil, task)created a wrapped task with a nil context.When a worker processed that task, evaluating
ctx.Err()panicked. The worker recovered the panic, but the submitted task was skipped.Fix
Normalize nil contexts inside
UpdateTask, matching the existingSubmitCtxbehavior.Validation
go test . -count=1go test -short ./... -count=1go test -race . -run '^TestAgilePoolUpdateTaskNilContextRunsTask$' -count=1go vet ./...Scope
No changes to hooks, scheduling, buffering, scaling, or public API shape.