Repository navigation
Fix native Windows runtime writes blocked by directory sharing locks - #11
Merged
Merged
Conversation
Use a simple target name with a null RootDirectory for atomic renames within the pinned runtime directory. Passing the directory handle caused Windows to reopen it for write access, conflicting with FILE_SHARE_READ. Retain directory locks and file identity checks. Document the fix and its native Windows validation scope in the changelog. Validated: baseline error 32 reproduction; create/replace/read including Unicode names and empty data; directory pin and unsafe-name rejection; dashboard project creation, settings save, and server restart recovery; Python syntax, git diff --check, and npm pack --dry-run. Research execution and paper generation were not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix native Windows project runtime writes failing with sharing violation 32
Loading or creating a project on native Windows failed while publishing
legacy_runtime_import.json. The temporary file was written successfully, but
NtSetInformationFile reopened the target directory for write access because the
rename supplied RootDirectory. That conflicted with the service's own directory
handle, which deliberately permits FILE_SHARE_READ only.
Use a simple target filename with a null RootDirectory to rename within the same
pinned directory. Retain the directory locks, atomic replacement, no-follow
handling, and file identity validation. Update the changelog with the fix and its
validation scope.
Validation
empty content, and a 1 MiB payload.
names are rejected.
project, created a project through the dashboard, saved Agent settings, and
verified project/settings persistence after restarting the server.
archive includes the runtime and excludes verification artifacts.
Research execution and paper generation were not run. Other operating systems
were not retested for this change.