This repository was archived by the owner on Jul 22, 2024. It is now read-only.
configurable chart granularity - #87
Open
jlambert121 wants to merge 1 commit into
Open
Conversation
jlambert121
force-pushed
the
chart_granularity
branch
from
December 26, 2021 14:55
e9c6d6c to
fbb1bdb
Compare
Author
|
@jlambert121 thank you this really looks good. For me, the only thing missing is to "sum" the precipitations instead of skipping them. Because let's say you display one third of the hours, you may be missing big rains during the two third of the hidden hours... and it would be great to know that instead of display "0" precip and a nice sunshine Whenever I tried tweaking the code, I never managed to do that but unfortunately I am really bad with this code language. Do you know how to add this feature? |
|
This is a great feature, I was looking exactly at that. I can't help with this code language either but would be a grateful user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I tend to get up very early in the morning (2a) and walking past my wall panel to look at the day I cannot get a good sense for what the hourly forecast is going to do since (on my machine) it only shows 8 hours which takes me up to 10a. I would like to instead see the hourly display for every other hour giving me a better picture of the entire day, but obviously less granularity.
Solution
I added a configuration option (I really struggled on the name, happy to change it) that allows changing the granularity of the chart graph, up to the maximum size of your weather forecast. The default should remain unchanged for everyone which is to just display the first
nelements.