Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

configurable chart granularity - #87

Open
jlambert121 wants to merge 1 commit into
Yevgenium:masterfrom
jlambert121:chart_granularity
Open

configurable chart granularity#87
jlambert121 wants to merge 1 commit into
Yevgenium:masterfrom
jlambert121:chart_granularity

Conversation

@jlambert121

Copy link
Copy Markdown

Background

I tend to get up very early in the morning (2a) and walking past my wall panel to look at the day I cannot get a good sense for what the hourly forecast is going to do since (on my machine) it only shows 8 hours which takes me up to 10a. I would like to instead see the hourly display for every other hour giving me a better picture of the entire day, but obviously less granularity.

Solution

I added a configuration option (I really struggled on the name, happy to change it) that allows changing the granularity of the chart graph, up to the maximum size of your weather forecast. The default should remain unchanged for everyone which is to just display the first n elements.

@jlambert121

jlambert121 commented Dec 26, 2021

Copy link
Copy Markdown
Author

This looks like it will resolve #79 and #74 as well.

@Sku4l

Sku4l commented May 23, 2022

Copy link
Copy Markdown

@jlambert121 thank you this really looks good. For me, the only thing missing is to "sum" the precipitations instead of skipping them.

Because let's say you display one third of the hours, you may be missing big rains during the two third of the hidden hours... and it would be great to know that instead of display "0" precip and a nice sunshine

Whenever I tried tweaking the code, I never managed to do that but unfortunately I am really bad with this code language. Do you know how to add this feature?

@alexbelgium

Copy link
Copy Markdown

This is a great feature, I was looking exactly at that. I can't help with this code language either but would be a grateful user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants