Add environment.3.8.erb for ZooKeeper 3.8 support - #20
Merged
Conversation
ZK 3.8 migrated from log4j to logback (ZOOKEEPER-4427). The ZOO_LOG4J_PROP environment variable is no longer used in 3.8 — logback handles logging configuration via logback.xml. This template is identical to environment.3.6.erb but with ZOO_LOG4J_PROP removed.
vulpine
approved these changes
Jun 8, 2026
vulpine
left a comment
vulpine
left a comment
There was a problem hiding this comment.
We could probably move this module inside the Yelpy Puppet repo
tub
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZK 3.8 migrated from log4j to logback (ZOOKEEPER-4427). The ZOO_LOG4J_PROP environment variable is no longer used in 3.8 — logback handles logging configuration via logback.xml.
This template is identical to environment.3.6.erb but with ZOO_LOG4J_PROP removed.