Kilted support - #22
Open
jimmy-mcelwain wants to merge 3 commits into
Open
Conversation
Fix was merged upstream micro-ROS/rcutils#50
Collaborator
Author
Just as a quick update, my fix got merged upstream, so I will rid of the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not get merged, but this can provide a place to look at the diff and discuss.
Builds micro-ros for kilted
Depends on #21, but can be separated out if needed
I used the following to figure out the tags:
This addition caused problems. Originally I was thinking about updating the motoman_posix_shim, but realized that the semantics are not supported on our controllers. So I just made a patch for it, but posted an issue here about getting it patched upstream. We could add a stub in the posix shim instead, but I think this makes sense.
I took
diagnostics_msgsout of the ignored packages because it is now needed forcontrol_msgssee hereI added a few new packages to the ignore packages that caused build problems.
I updated a few patches that broke because of upstream updates. It is a little bit tedious but not too bad. I just did the following
git checkout -b port <new base sha>git am --3way path/to/patches/*.patchgit format-patch <new base sha> -o $/path/to/repo/package/