Skip to content

Kilted support - #22

Open
jimmy-mcelwain wants to merge 3 commits into
jazzy_patchesfrom
kilted
Open

Kilted support#22
jimmy-mcelwain wants to merge 3 commits into
jazzy_patchesfrom
kilted

Conversation

@jimmy-mcelwain

@jimmy-mcelwain jimmy-mcelwain commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

This should not get merged, but this can provide a place to look at the diff and discuss.

Builds micro-ros for kilted

Depends on #21, but can be separated out if needed

I used the following to figure out the tags:

  • ros2 repos: chose the matching kilted release
  • micro-ros repos: Just chose the most recent commit for each one (micro-ros setup just points to the branch).
  • extra repos
  • eProsima repos: the ros2 branches pointed at by micro-ros setup haven't changed in years, so I kept those the same.

This addition caused problems. Originally I was thinking about updating the motoman_posix_shim, but realized that the semantics are not supported on our controllers. So I just made a patch for it, but posted an issue here about getting it patched upstream. We could add a stub in the posix shim instead, but I think this makes sense.

I took diagnostics_msgs out of the ignored packages because it is now needed for control_msgs see here

I added a few new packages to the ignore packages that caused build problems.

I updated a few patches that broke because of upstream updates. It is a little bit tedious but not too bad. I just did the following

  1. Clone upstream repos
  2. git checkout -b port <new base sha>
  3. git am --3way path/to/patches/*.patch
  4. repeat step 3, resolving conflicts as needed
  5. git format-patch <new base sha> -o $/path/to/repo/package/

@jimmy-mcelwain

Copy link
Copy Markdown
Collaborator Author

This addition caused problems. Originally I was thinking about updating the motoman_posix_shim, but realized that the semantics are not supported on our controllers. So I just made a patch for it, but posted an issue micro-ROS/micro_ros_setup#813 about getting it patched upstream. We could add a stub in the posix shim instead, but I think this makes sense.

Just as a quick update, my fix got merged upstream, so I will rid of the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant