Repository navigation
enforce origin checks between editor and content iframe - #164
Merged
Merged
Conversation
The iframe logged disallowed origins but still accepted their editor port, so any site framing a page could drive the content editor. The origin check also used unanchored matching, so a string like "http://localhost:3000" matched "http://localhost:3000.evil.com". - Ignore messages that are not a Yancy.init request with a port - Stop handling messages from origins that are not allowed - Compare string origins exactly, and require RegExps to match the whole origin - Default allowOrigins to the page's own origin, and set it even when window.Yancy already exists - Ignore editor commands that are not editor chain methods - Send the editor port only to the site origin instead of "*", so a page the iframe navigated to can not receive it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iframe logged disallowed origins but still accepted their editor port, so any site framing a page could drive the content editor. The origin check also used unanchored matching, so a string like "http://localhost:3000" matched "http://localhost:3000.evil.com".