Repository navigation
prevent storage ids from escaping the storage root - #158
Merged
Merged
Conversation
Storage IDs were passed straight to Mojo::File->child, so IDs with `..` parts (e.g. `/storage/..%2F..%2Fetc%2Fpasswd`) and upload filenames like `../../x` could read, write, or delete files outside of the root. Add Yancy::Storage->valid_id, which rejects empty IDs, `.` and `..` parts, backslashes, and NUL characters, and check it in get, put, and delete. The storage controller returns 404/400 for invalid IDs, and only uses the file name part of an upload's filename. Also return undef from get when the file does not exist, so the controller can respond with 404. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage IDs were passed straight to Mojo::File->child, so IDs with
..parts (e.g./storage/..%2F..%2Fetc%2Fpasswd) and upload filenames like../../xcould read, write, or delete files outside of the root.Add Yancy::Storage->valid_id, which rejects empty IDs,
.and..parts, backslashes, and NUL characters, and check it in get, put, and delete. The storage controller returns 404/400 for invalid IDs, and only uses the file name part of an upload's filename.Also return undef from get when the file does not exist, so the controller can respond with 404.