feat: make ap_in_ff sorry-free - #16
Conversation
|
Now that I have merged #15, you need to fix the merge conflicts here. |
58f3d64 to
80612f7
Compare
|
Sorry, I just pushed a large refactor to use the material that was newly upstreamed from APAP to AddCombi in leanprover-community/add-combi#2. You will need to resolve conflicts again. |
80612f7 to
afc35b9
Compare
|
Rebased on current master |
afc35b9 to
788718e
Compare
|
Rebased on current master |
YaelDillies
left a comment
There was a problem hiding this comment.
Can you try generalising each of the prerequisite lemmas and moving them to earlier files?
|
Thanks, I followed your suggestions by moving the reusable lemmas to earlier files, applying the generalizations and using |
|
Thanks, I updated the remaining points as suggested and did another small cleanup pass. |
|
Fixed the build failure that my local stale .olean files had missed. |
YaelDillies
left a comment
There was a problem hiding this comment.
Can you update the blueprint too? You need to add \leanok in the ff item.
Doesn't the ff item already have \leanok? I see it in blueprint/src/chapter/ff.tex right after \lean{ff}. |
|
Oh sorry, I mean (the proof of) |
ap_in_ff sorry-free
fb40a16 to
1ee1cd4
Compare
|
Removed the local preimage lemma and rewrote the use through AddMonoidHomClass.isAddFreimanHom ... .threeAPFree. |
c63415a to
3221bf2
Compare
68b3499 to
4b0f0e9
Compare
f079cd4 to
41f10d6
Compare
cb1b8a4 to
b487e3c
Compare
b487e3c to
6f3b62a
Compare
Fill the remaining
sorrys in the finite-field almost-periodicity proof, in particular the final gap in:The main changes are in:
The proof adds private helper lemmas for the common-kernel/Fourier-closure bridge, controls the off-closure Fourier mass by comparing
Fwithμ T ∗^ k ∗ F, and uses a Fourier-L1 smooth-tail estimate for the specific convolution structure appearing in the finite-field argument.There is a substantial amount of code, so I have tried to keep the new auxiliary lemmas private/local to
APAP/FiniteField.leanwhere possible. The only non-local supporting change is a small prerequisite adjustment in:allowing the compact Hölder lemmas to be used under a
[Finite α]assumption rather than only an existing[Fintype α]instance.The quantitative statement is not weakened: the proof preserves the existing
2 ^ 32codimension bound.Note: Produced with assistance from a prototype agentic Lean proof-search system. Codex was used for review, refinement and simplification.