Backoff mechanic Exponential#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an exponential backoff mechanic with a new Exponential backoff implementation and comprehensive tests.
- Adds an Exponential backoff strategy in exponential.go
- Implements tests in yabackoff_test.go to verify behavior for next interval, reset, maximum interval, and sleep functionality
- Updates the module dependencies in go.mod to include testify for testing
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yabackoff/yabackoff_test.go | Added tests for the exponential backoff mechanism |
| yabackoff/yabackoff.go | Provided the Backoff interface and default constants |
| yabackoff/exponential.go | Implemented the Exponential backoff strategy |
| go.mod | Included testify dependency for testing |
Comments suppressed due to low confidence (2)
yabackoff/yabackoff_test.go:38
- The helper function 'min' is used but not defined in this file, which might cause a compilation error. Consider defining or importing a min function.
next := min(time.Duration(float64(last)*multiplier), maxInterval)
yabackoff/exponential.go:100
- The helper function 'min' is used but not defined, potentially causing a compilation error. Consider defining or importing an appropriate min function.
e.currentInterval = min(time.Duration(float64(e.currentInterval)*e.multiplier), e.maxInterval)
YaCodesDevelopment
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.