Skip to content

chore(test): 미션 테스트 제거 및 Harness 업데이트 - #274

Merged
pbk95120 merged 1 commit into
developfrom
chore/remove-mission-tests
Sep 18, 2026
Merged

pbk95120 merged 1 commit into
developfrom
chore/remove-mission-tests

Conversation

@pbk95120

@pbk95120 pbk95120 commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

📝 작업 내용 요약

  • 미션 기능 제거 준비로 웹·네이티브·공용 스키마의 미션 전용 테스트 27개 파일을 삭제했습니다.
  • 공용 테스트 파일에서는 미션 검증만 제거하고, 내비게이션·안전 영역 검증은 혜택 경로로 유지했습니다.
  • 다른 기능 테스트 실행에 필요한 미션 API 목과 실제 미션 기능 코드는 유지했습니다.
  • Harness 서브모듈을 a1eaaf4에서 최신 확인 커밋 2bdaee4로 업데이트했습니다.

✅ 체크리스트

  • develop 브랜치의 최신 코드를 pull 받았나요? (origin/develop 기반 브랜치 생성 및 fetch 확인)
  • 빌드가 통과했나요?
  • vitest 테스트가 통과했나요? (웹 348개)
  • Playwright e2e가 통과했나요? (23개)

🤖 AI 리뷰

Claude 리뷰 (Codex 구현)

  • Claude Opus 5 리뷰를 시도했으나 Not logged in · Please run /login으로 실행하지 못했습니다.
  • 사용자 승인으로 독립 AI 리뷰를 생략했습니다. 리뷰 통과 판정은 없습니다.
  • 전체 lint, typecheck, test, build 20개 작업 통과. 커밋 후 재검증은 Turbo 캐시를 사용했고, E2E 23개도 통과했습니다.

💬 기타 코멘트

  • 사용자 승인으로 서브모듈 업데이트와 테스트 제거를 하나의 PR로 묶었습니다.
  • 미션 기능은 아직 동작하지만 해당 기능의 회귀 테스트 보호는 제거됩니다. 기능 코드 삭제는 후속 작업입니다.

변경 사항

  • 미션 기능 제거를 준비하기 위해 웹·네이티브·공용 스키마의 미션 전용 테스트를 삭제했습니다.
  • 공용 테스트에서는 미션 검증을 제거하고, 내비게이션 및 안전 영역 검증을 혜택 경로 기준으로 유지했습니다.
  • 다른 기능 테스트에 필요한 미션 API 목과 실제 미션 기능 코드는 유지했습니다.
  • Harness 서브모듈 참조를 a1eaaf4에서 2bdaee4로 업데이트했습니다.

테스트

  • 빌드 통과
  • Vitest 테스트 348개 통과
  • Playwright E2E 테스트 23개 통과

@pbk95120 pbk95120 self-assigned this Sep 17, 2026
@pbk95120
pbk95120 requested a review from jongse7 September 17, 2026 23:54
@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
28th-web-team-3-fe-web-dev Ready Ready Preview Sep 17, 2026 11:54pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
28th-web-team-3-fe-admin Ignored Ignored Sep 17, 2026 11:54pm UTC

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3942ebd0-45fc-4bc8-accb-fbbf9bbbfaf9

📥 Commits

Reviewing files that changed from the base of the PR and between ca5396e and 8286f7b.

📒 Files selected for processing (35)
  • Harness
  • apps/native/src/guest-state.test.ts
  • apps/native/src/mission-generation/history.test.ts
  • apps/native/src/mission-generation/pending-job.test.ts
  • apps/web/app/(tabs)/_components/pigbox-progress-gauge.test.tsx
  • apps/web/app/(tabs)/_components/weekly-mission-section.test.tsx
  • apps/web/app/(tabs)/mission/_components/mission-add-menu.test.tsx
  • apps/web/app/(tabs)/mission/page.test.tsx
  • apps/web/app/(tabs)/page.test.tsx
  • apps/web/app/_components/bottom-nav.test.tsx
  • apps/web/app/_components/loading-states.test.tsx
  • apps/web/app/_components/pending-mission-generation-recovery.test.tsx
  • apps/web/app/_components/safe-area-color.test.tsx
  • apps/web/app/mission/_components/mission-creation-result.test.tsx
  • apps/web/app/mission/_components/mission-loading.test.tsx
  • apps/web/app/mission/constants/mission-creation.test.ts
  • apps/web/app/mission/history/_components/mission-history.test.tsx
  • apps/web/app/mission/history/lib/month.test.ts
  • apps/web/app/mission/history/lib/weekly-history.test.ts
  • apps/web/app/mission/new/loading/page.test.tsx
  • apps/web/app/mission/new/manual/page.test.tsx
  • apps/web/app/mission/new/page.test.tsx
  • apps/web/app/mission/new/utils/mission-chat.test.ts
  • apps/web/app/mission/new/utils/mission-creation-history.test.ts
  • apps/web/app/mission/new/utils/pending-mission-generation.test.ts
  • apps/web/e2e/mission-complete-dialog.spec.ts
  • apps/web/e2e/mission-history.spec.ts
  • apps/web/e2e/mission-onboarding.spec.ts
  • apps/web/e2e/mission-polling.spec.ts
  • apps/web/e2e/touch-targets.spec.ts
  • apps/web/lib/queries/mission-generation.test.ts
  • apps/web/lib/safe-area-bands.test.ts
  • apps/web/src/api/mission.test.ts
  • packages/schema/src/mission-generation.test.ts
  • packages/schema/src/mission.test.ts
💤 Files with no reviewable changes (29)
  • apps/web/app/mission/history/lib/month.test.ts
  • packages/schema/src/mission.test.ts
  • apps/web/app/mission/new/utils/pending-mission-generation.test.ts
  • apps/web/e2e/mission-onboarding.spec.ts
  • apps/web/lib/queries/mission-generation.test.ts
  • apps/web/e2e/touch-targets.spec.ts
  • apps/native/src/mission-generation/history.test.ts
  • apps/web/app/mission/_components/mission-creation-result.test.tsx
  • apps/web/src/api/mission.test.ts
  • apps/web/app/mission/new/utils/mission-chat.test.ts
  • packages/schema/src/mission-generation.test.ts
  • apps/web/e2e/mission-polling.spec.ts
  • apps/web/app/(tabs)/mission/_components/mission-add-menu.test.tsx
  • apps/web/app/_components/pending-mission-generation-recovery.test.tsx
  • apps/web/app/mission/new/manual/page.test.tsx
  • apps/web/app/(tabs)/_components/weekly-mission-section.test.tsx
  • apps/web/app/(tabs)/mission/page.test.tsx
  • apps/web/app/mission/history/_components/mission-history.test.tsx
  • apps/web/app/mission/new/page.test.tsx
  • apps/web/app/mission/_components/mission-loading.test.tsx
  • apps/native/src/mission-generation/pending-job.test.ts
  • apps/web/app/(tabs)/_components/pigbox-progress-gauge.test.tsx
  • apps/web/app/mission/constants/mission-creation.test.ts
  • apps/web/e2e/mission-complete-dialog.spec.ts
  • apps/web/app/mission/new/loading/page.test.tsx
  • apps/web/e2e/mission-history.spec.ts
  • apps/native/src/guest-state.test.ts
  • apps/web/app/mission/new/utils/mission-creation-history.test.ts
  • apps/web/app/mission/history/lib/weekly-history.test.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

미션 관련 단위 테스트와 E2E 테스트를 삭제했습니다. 일부 홈, 내비게이션, 안전 영역 테스트는 새 경로와 축소된 검증 대상으로 변경했습니다. 하위 프로젝트 참조도 새 커밋으로 갱신했습니다.

Changes

하위 프로젝트 참조 갱신

Layer / File(s) Summary
하위 프로젝트 커밋 포인터 변경
Harness
하위 프로젝트 참조를 a1eaaf4...에서 2bdaee4...로 변경했습니다.

미션 테스트 범위 조정

Layer / File(s) Summary
네이티브 생성 상태 테스트 삭제
apps/native/src/guest-state.test.ts, apps/native/src/mission-generation/*
미션 생성 이력, 대기 작업, 게스트 상태 정리 호출 검증을 제거했습니다.
웹 미션 생성 흐름 테스트 삭제
apps/web/app/mission/new/**, apps/web/app/mission/_components/*, apps/web/app/_components/pending-mission-generation-recovery.test.tsx, apps/web/lib/queries/mission-generation.test.ts, apps/web/e2e/mission-{onboarding,polling}.spec.ts
미션 생성 입력, 폴링, 복구, 결과 표시, 대기 작업 정리와 관련된 테스트를 삭제했습니다.
미션 화면과 이력 테스트 삭제
apps/web/app/(tabs)/_components/*, apps/web/app/(tabs)/mission/page.test.tsx, apps/web/app/mission/history/**, apps/web/e2e/mission-{complete-dialog,history}.spec.ts
미션 목록, 진행 게이지, 주간 미션, 이력, 완료 다이얼로그 테스트를 삭제했습니다.
공통 화면 및 경로 테스트 변경
apps/web/app/(tabs)/page.test.tsx, apps/web/app/_components/*, apps/web/e2e/touch-targets.spec.ts, apps/web/lib/safe-area-bands.test.ts
홈의 미션 검증을 제거했습니다. 내비게이션 경로를 /benefits/saved로 변경했습니다. 안전 영역과 로딩 상태 검증을 새 대상에 맞게 조정했습니다.
미션 API와 스키마 테스트 삭제
apps/web/src/api/mission.test.ts, packages/schema/src/mission*.test.ts
미션 API 요청·응답, 생성 요청, 미션 응답, 진행률과 이력 스키마 테스트를 삭제했습니다.
미션 생성 상수 테스트 삭제
apps/web/app/mission/constants/mission-creation.test.ts
카테고리 순서와 API 코드 매핑 테스트를 삭제했습니다.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 8286f

The change removes mission-specific test coverage in preparation for feature removal, while preserving replacement coverage for shared benefits, navigation, and safe-area paths. No actionable merge-blocking issue is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 미션 테스트 삭제와 Harness 업데이트라는 변경 사항의 주요 내용을 정확하고 간결하게 요약합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 5…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pbk95120
pbk95120 merged commit f4f854d into develop Sep 18, 2026
6 of 7 checks passed
@pbk95120
pbk95120 deleted the chore/remove-mission-tests branch September 18, 2026 00:54

This branch was successfully deployed

1 active deployment
Preview – 28th-web-team-3-fe-web-dev — 8286f7b5 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant