-
Notifications
You must be signed in to change notification settings - Fork 0
[FEAT] AOP 기반 페이지 조회 카운터 메트릭 수집 기능 구현 #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LEEJaeHyeok97
wants to merge
2
commits into
develop
Choose a base branch
from
feat/monitoring
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
src/main/kotlin/com/coffee/api/common/aop/PageViewAspect.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.coffee.api.common.aop | ||
|
|
||
| import io.micrometer.core.instrument.MeterRegistry | ||
| import org.aspectj.lang.JoinPoint | ||
| import org.aspectj.lang.annotation.Aspect | ||
| import org.aspectj.lang.annotation.Before | ||
| import org.springframework.stereotype.Component | ||
|
|
||
| @Aspect | ||
| @Component | ||
| class PageViewAspect( | ||
| private val meterRegistry: MeterRegistry | ||
| ) { | ||
|
|
||
| @Before("@annotation(pageViewed)") | ||
| fun countPageView(joinPoint: JoinPoint, pageViewed: PageViewed) { | ||
| val counterName = "page.view.count" | ||
| val tagName = pageViewed.name | ||
|
|
||
| meterRegistry | ||
| .counter(counterName, "page", tagName) | ||
| .increment() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package com.coffee.api.common.aop | ||
|
|
||
| @Target(AnnotationTarget.FUNCTION) | ||
| @Retention(AnnotationRetention.RUNTIME) | ||
| annotation class PageViewed(val name: String) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package com.coffee.api.config.aop | ||
|
|
||
| import io.micrometer.core.aop.CountedAspect | ||
| import io.micrometer.core.instrument.MeterRegistry | ||
| import org.springframework.context.annotation.Bean | ||
| import org.springframework.context.annotation.Configuration | ||
|
|
||
| @Configuration | ||
| class CafeConfig { | ||
|
|
||
| @Bean | ||
| fun countedAspect(registry: MeterRegistry): CountedAspect = | ||
| CountedAspect(registry) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
페이지 뷰 측정을 위한 AOP 구현
페이지 뷰 메트릭을 수집하기 위한 AOP 클래스를 구현했습니다.
@PageViewed애노테이션이 적용된 메서드 실행 전에 메트릭을 증가시키는 방식으로 구현되었습니다.하지만 몇 가지 개선할 점이 있습니다:
📝 Committable suggestion