feat: web workbench v2 overview - #36
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
当前实现引入了信息展示缺失与重复计算（evidence bundle）的问题，需要先修正以避免误导页面状态并降低不必要的开销。
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
该 PR 为只读 Web 工作台补充展示 v2 的“总体状态”，并在 web payload 中新增 overview 字段（由 generate_v2_overview() 生成），以便在页面上呈现 v2 总览信息。
Changes:
- Web 工作台 HTML 渲染新增一行展示 v2
overall_status。 - Web payload 生成逻辑新增
overview: generate_v2_overview(prepared)。 - 更新 CHANGELOG 与 ROADMAP 记录该能力已完成。
File summaries
| File | Description |
|---|---|
| src/goratio/web.py | 在仪表盘表格中插入 v2 总体状态行（读取 payload.overview） |
| src/goratio/cli.py | web 命令的 payload 新增 overview 字段 |
| CHANGELOG.md | 记录 Web 工作台支持 v2 总体状态与 overview payload |
| .planning/ROADMAP.md | 标记“Web 工作台已显示 v2 总体状态”为完成 |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
630
to
634
| "factor": factor_snapshot(prepared), | ||
| "evidence": run_v2_evidence_bundle(prepared), | ||
| "overview": generate_v2_overview(prepared), | ||
| "risk_flags": ( | ||
| ["insufficient_history"] if not prepared.evidence_eligible else [] |
Comment on lines
+49
to
58
| overview = payload.get("overview", {}) | ||
| if overview.get("overview"): | ||
| rows.insert( | ||
| 0, | ||
| "<tr><td>v2 总体状态</td><td>" | ||
| + e(str(overview["overview"].get("overall_status", "未知"))) | ||
| + "</td></tr>", | ||
| ) | ||
| if not rows: | ||
| rows.append("<tr><td>因子状态</td><td>不可用</td></tr>") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web 工作台显示 v2 总体状态并携带 overview payload。