feat: generated_at timestamp in formal report - #28
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
新增的测试仅验证字段存在性，未覆盖“UTC 生成时间（Z 后缀/可解析）”这一需求点，容易让时区或格式回归漏检。
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
为协议 v2 的正式验收报告（formal_v2.generate_v2_formal_report()）增加一个 UTC 生成时间字段，便于审计与追踪报告生成时点。
Changes:
- 在
generate_v2_formal_report()返回结构中新增generated_at（UTC，ISO-8601 /Z后缀）。 - 更新对应单测，确保报告结构包含该字段。
- 在变更日志与路线图中记录该能力已落地。
File summaries
| File | Description |
|---|---|
| tests/test_formal_v2.py | 新增对 generated_at 字段存在性的断言（建议补强为 UTC/可解析格式校验）。 |
| src/goratio/formal_v2.py | 在 v2 formal report 顶层新增 generated_at UTC 时间戳输出。 |
| CHANGELOG.md | 记录 generate_v2_formal_report() 新增 generated_at。 |
| .planning/ROADMAP.md | 路线图勾选：formal report 已带 generated_at。 |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| self.assertEqual(report["protocol"], "goratio-2a-v1") | ||
| self.assertEqual(report["overall_status"], "insufficient_data") | ||
| self.assertIn("generated_at", report) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_v2_formal_report 输出 UTC 生成时间。