Refactor/unify-feedback-gateway#502
Conversation
…d add AppShell for centralized service initialization
…ion by returning IDs directly
… include unit tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request unifies user-facing feedback by replacing the legacy diagnostics and notifications services with a centralized FeedbackService facade across the launcher and the SDK. Key changes include a Rust-backed feedback channel with priority sorting and auto-expiry, new UI components like FeedbackBar and FeedbackDetailsDialog, and updated SDK contracts. The review feedback highlights several critical issues: in Rust, dismissing queued items can spawn duplicate active timers, finishing progress items can leave the queue unsorted, and publishing queued items schedules redundant expiry timers. On the frontend, potential TypeErrors exist from unsafe context access, progress counts can render as null values, and floating promises are created by unawaited feedbackService.report calls.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
No description provided.