ci: report patch coverage instead of hiding it#116
Merged
Conversation
patch: off was right when the frontend sat at 7.9% and any patch status would have been red on every PR — a check nobody reads is worse than none. At 69% it only hides the number: the project status cannot stand in for it, since api-server's ~3 700 statements make its 1% band worth ~50 entirely uncovered new lines, and a wave lands as many small PRs that each fit inside it. informational, so it reports without ever failing a merge. Validated against Codecov's own /validate endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch: off was right when the frontend sat at 7.9% and any patch status would have been red on every PR — a check nobody reads is worse than none. At 69% it only hides the number: the project status cannot stand in for it, since api-server's ~3 700 statements make its 1% band worth ~50 entirely uncovered new lines, and a wave lands as many small PRs that each fit inside it.
informational, so it reports without ever failing a merge. Validated against Codecov's own /validate endpoint.