add some easy test#115
Merged
Merged
Conversation
App.tsx pulls in every page and builds the router at module scope, so the one piece of logic in it that decides whether a browser is signed in could not be exercised without mounting the whole application.
The boot probe's 401-vs-anything-else rule is what makes the api-server's 503 worth answering: reading an outage as "signed out" would sign the fleet out, which is precisely what the 503 exists to prevent. The SSO landing's clearLocal-not-logout decision has the same shape — one hiccuping profile fetch must not revoke the account everywhere.
Both are swallowed on purpose — the queue is best-effort and the next event re-queues — so nothing but a test proves they do not take the consumer loop down with them, nor that a deleted image stays silent while an unreachable API server does not.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
The first version asserted only that no entries appeared for a name no fixture ever wrote — a syncPending emptied of its whole body passed it. It now leads with the nominal case, so doing nothing fails, and captures slog to hold the distinction its own comment claimed: a delete event stays silent, an unreachable API server does not. Same blind spot on the frontend: every case answered any path, so a probe pointed at a route that does not exist would have kept both suites green while sending the whole fleet to the unavailable screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend & go