fix: skip prerequisite checks when not building root design#123
Open
taraxacum45e9a wants to merge 1 commit into
Open
fix: skip prerequisite checks when not building root design#123taraxacum45e9a wants to merge 1 commit into
taraxacum45e9a wants to merge 1 commit into
Conversation
taraxacum45e9a
force-pushed
the
pr-depchk
branch
from
10f492b to
e182626
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v++and SMBus IP prerequisite checks inpackage-deb.share only relevant when building the root design. Previously they ran unconditionally, causing failures in environments whereSLASH_PKG_SKIP_ROOT_DESIGN_BUILDis set (i.e. the root design build is skipped and a pre-built one is used instead).