Fix Vivado missing IP repository warning on clean builds#118
Open
taraxacum45e9a wants to merge 1 commit into
Open
Fix Vivado missing IP repository warning on clean builds#118taraxacum45e9a wants to merge 1 commit into
taraxacum45e9a wants to merge 1 commit into
Conversation
48d52c1 to
fa869ac
Compare
fa869ac to
d003a30
Compare
config.ip_repository defaults to a subdirectory inside build_dir. Since build_dir is recreated fresh on every build, ip_repository may not exist yet. Check for its existence before appending it to the command to prevent errors. Signed-off-by: Shen Jiamin <shen_jiamin@comp.nus.edu.sg>
d003a30 to
e7116b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.ip_repositorydefaults to a subdirectory insidebuild_dir.SLASH/linker/slashkit/core/command_config.py
Lines 101 to 102 in a11e728
Because
build_diris wiped and recreated on every build,ip_repositorymay not exist yet whencreate_build_projectis called.SLASH/linker/slashkit/core/command_config.py
Lines 374 to 376 in a11e728
Previously it was unconditionally appended to the Vivado command line, which could cause the tool to warn on a clean build.
The fix checks
config.ip_repository.exists()before appending, so the argument is only passed when the directory is actually present.