[nosjo]

Not to happy with my changes but not sure what other way can be done to fix #150

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[XeroxDev]

IMO this resolution is fine in regards of the linked ticket. But could provide some screenshots to display how the change is looking (and how/where the new messages are displayed)?

[nosjo]

It displays it like this upon connection issues https://share.nosjo.xyz/KBjLRB.png
All other errors will still be displayed as before

[XeroxDev]

Looks good for me. Will be deployed with the next update in the future (such a small change doesn't justify an entire update yet)

[nosjo]

Slight mistake was meant to open a new pull request for those changes but oh well guess this works

This new commit adds support for showing song title, author or album instead of the play/pause text
and also adds support for inputting path to a custom layout to use and can populate text fields in said custom layout automatically if key names are correct

This also depends on XeroxDev/Stream-Deck-TS-SDK#21

Before

After

The new settings

Picture of custom layout example

[Copilot]

Pull Request Overview

This PR adds Stream Deck+ support for displaying song titles with custom layouts and improves error handling for connection states. The main purpose is to enhance the Stream Deck+ encoder experience with better metadata display and customizable layouts.

Key Changes:

• Added new settings for Stream Deck+ including title format customization and custom layout file support
• Enhanced error handling to distinguish between websocket errors and other connection issues
• Modified thumbnail rendering to support larger display sizes (100x100 instead of 48x48)

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/ytmd-pi.ts	Added new input element properties for title format, SD+ settings, and custom layout configuration
src/pis/play-pause.pi.ts	Implemented controller type detection to conditionally display SD+ settings and added new setting fields
src/interfaces/context-settings.interface.ts	Extended PlayPauseSettings interface with displayTitleFormat and customLayout properties
src/actions/play-pause.action.ts	Refactored song data handling, added title formatting logic, improved error handling, and implemented custom layout support
property-inspector.html	Added UI elements for SD+ settings including title format and custom layout configuration
package.json	Updated streamdeck-typescript and ytmdesktop-ts-companion package versions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The customLayout property is defined as a string in the interface (context-settings.interface.ts line 9), but the default value here is false (boolean). This should be an empty string ('') to match the type definition.

Suggested change

	customLayout: customLayout ?? false
	customLayout: customLayout ?? ''

[XeroxDev]

I let copilot review the code as well to test it out. You don't have to implement everything it says.

[XeroxDev]

@nosjo could you maybe rebase this pr / resolve merge conflicts (I changes some things regarding development and build process) and also remind me if you wanted to add / change some things as well.

(with the new workflow I can easier release builds from everywhere)

[nosjo]

@XeroxDev of course i get it done sometime soon

[XeroxDev]

Short update: the rebase / merge conflict could be a bit more complex now, because I refactored a lot more recently. Especially PI stuff changed heavily. I'm sorry 😅

[nosjo]

Not sure what else i wanted to add been to long and forgot but it should all work now with the new PI stuff.
And must say i like how its changed much easier to work with compared to before 😄

[nosjo]

oh yeah also needs this XeroxDev/Stream-Deck-TS-SDK#41 merged almost forgot that would be bad without

[XeroxDev]

oh yeah also needs this XeroxDev/Stream-Deck-TS-SDK#41 merged almost forgot that would be bad without

The linked pull request seems empty? 😅

[XeroxDev]

I noticed in the package json you've updated the streamdeck lib version.

Currently latest version is 3.3.4.

So we should make sure we use the latest version, especially after the pr you mentioned in the comments.

(github bugs, so I can't put that comment to the correct line nor do it as a review ._.)

[nosjo]

Yeah my mistake thought the code was not in the streamdeck lib but i was wrong and did not notice that it actually was there so changed the version to the current 3.3.4

[XeroxDev]

One last thing: I noticed a mismatch: package.json bumps streamdeck-typescript to ^3.3.4, but the lockfile still resolves it to 3.2.1 (or at least contains that resolution).
Could you regenerate the lockfile from scratch (rm -rf node_modules package-lock.json && npm install) so package-lock.json resolves streamdeck-typescript to >= 3.3.4? Then we’re good to release.

[nosjo]

Just ran npm update and that updated it in the file, deleted the modules folder a bit earlier just to test that everything compiled fine so know that folder is clean.