Minor Saturn build system - #3460
Merged
Merged
Conversation
sozud
reviewed
Aug 1, 2026
| config["objdump_executable"] = ( | ||
| "sh-elf-objdump" if version == "saturn" else "mipsel-linux-gnu-objdump" | ||
| ) | ||
| config["objdump_executable"] = "mipsel-linux-gnu-objdump" |
Collaborator
There was a problem hiding this comment.
unless I'm missing something I don't think mipsel objdump is doing to work?
Owner
Author
There was a problem hiding this comment.
That is for the PS1 build. The Saturn one is at line 28, and it uses sh-elf-objdump
sozud
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously diffing Saturn locally was pointing to the wrong files. This attempts to fix that.
DIffing locally is still broken, I am unsure since which commit. But this at least fixes the obvious problems.