extract psp sfx, integrate in maria mod - #3457
Open
sozud wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Should the maria mod build have access to sd_mar2.spk on CI or should it just be able to build without it? I think it makes sense to provide the file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the psp format maria samples and implements them for psx. I've left in a maria ps1 sound test and one for psp since I anticipate this may need more debugging. This adds a one-off tool maria-sfx but my eventual plan would be to extract through the assets system for psp then recombine through the psx system.
This also includes a random fix for cmake where sotn_str that's annoying if you're using containers (e.g. you have a linux container but the host is mac and sotn_str is mutually incompatible).
2026-08-01.00-02-26.mp4