Skip to content

Code-share RNO0 create_entity between PS1 and PSP - #3450

Merged
Xeeynamo merged 1 commit into
Xeeynamo:masterfrom
mathisto:decomp-rno0-create-entity
Aug 1, 2026
Merged

Code-share RNO0 create_entity between PS1 and PSP#3450
Xeeynamo merged 1 commit into
Xeeynamo:masterfrom
mathisto:decomp-rno0-create-entity

Conversation

@mathisto

@mathisto mathisto commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

share

Summary

Code-shares the complete RNO0 create_entity helper family between the US PlayStation and PSPEU builds using the existing implementation in src/st/create_entity.h.

This replaces 15 INCLUDE_ASM stubs on each platform with one shared source implementation.

Target Functions matched Matching function bytes
US PS1 15 / 15 2,936
PSPEU 15 / 15 3,980

Total: 30 platform-specific INCLUDE_ASM stubs replaced by shared C.

Background

RNO0 had separate PlayStation and PSP stub files for the same complete create_entity helper family. These routines are already decompiled in the shared src/st/create_entity.h implementation used by other overlays.

Verification

  • US PlayStation build matches the target hash
  • PSPEU build matches the target hash
  • All 15 functions match on both platforms

@mathisto
mathisto marked this pull request as ready for review July 31, 2026 00:16

@Xeeynamo Xeeynamo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these are helpful!

@Xeeynamo
Xeeynamo merged commit 0b88d2e into Xeeynamo:master Aug 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants