Redesign three-line poem page to immersive layout and liquid‑glass comments - #30
Redesign three-line poem page to immersive layout and liquid‑glass comments#30XRYua wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a1e580090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /* three-line-poem immersive liquid glass enhancements */ | ||
| #three-line-twikoo { | ||
| position: relative; | ||
| } | ||
|
|
There was a problem hiding this comment.
Load twikoo.css before relying on its three-line overrides
These selectors never take effect as written because the new rules were moved out of ThreeLinePoemActivity.astro, but src/styles/twikoo.css still is not imported anywhere in the repo (I checked Layout.astro, ThreeLinePoemActivity.astro, and a repo-wide rg -n "twikoo.css" src). As a result, both /three-line-poem/ and the embedded /three-line-poem-space/ fall back to Twikoo’s default styling, so the liquid-glass redesign in this commit does not actually ship.
Useful? React with 👍 / 👎.
Motivation
Description
src/pages/three-line-poem.astroby usingLayoutand a full‑height.immersive-page-shellcontainer.src/components/ThreeLinePoemActivity.astrointo a two‑column immersive layout: left column is an intro/stats panel and right column contains the comment studio, with responsive fallbacks.mizuki-three-line-poems, includingreadLegacyPoems,renderLegacyPoems, a#legacy-poem-listUI, a refresh button and in‑place like handling so old comments are restored and can be liked.#three-line-twikooelement and introduce asetupThreeLinePoemPage()initializer that runs onDOMContentLoaded,swupcontent replace andstorageevents to keep comments consistent after navigation.src/styles/twikoo.cssto give inputs, comment cards and action areas a softened glassy appearance while preserving the site color variables.Testing
git diff --checkto ensure no whitespace/errors from the diff and fixed style issues where necessary (passed).pnpm astro checkto validate build types and Astro diagnostics; this run reported unrelated existing errors in the project (duplicate identifier forThreeLinePoemEntryinsrc/pages/[...page].astro) and therefore the check did not complete cleanly; the errors are pre‑existing and not caused by these changes.src/pages/three-line-poem.astro,src/components/ThreeLinePoemActivity.astro, andsrc/styles/twikoo.csswere formatted/updated locally.Codex Task