Fixes to get the public context running again#382
Open
HenningSE wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to get the public context running again. The most important changes are summarized below.
S1 LCE Correction Map Refactor
lce_from_pattern_mapincontext_utils.pyto build an S1 LCE correction map directly from an S1 pattern map, and registered it as aURLConfigendpoint. This makes LCE map construction modular and reusable.S1PhotonHitsplugin to use the newlce_from_pattern_mapfunction via astraxen.URLConfigentry fors1_lce_correction_map, simplifying configuration and improving maintainability.setupmethod inS1PhotonHits, as it is now handled by the newURLConfigmechanism.Map Handling Improvements
DummyMapclass to support initialization from a map dictionary, allowing it to be used seamlessly with maps produced or modified outside the class (e.g., bylce_from_pattern_map).Data Type Consistency
singlet_triplet_delaysand_luminescence_timings_simpleins2_photon_propagation.pyare always of typenp.int64, preventing downstream type errors. [1] [2]Other
comsolfield distortion model inelectron_drift.pyto ensure it is only used when the comsol option is actually used.