Skip to content

Changed Logs to Year-Month-Day - #426

Open
tecknojock wants to merge 1 commit into
WreckedAvent:masterfrom
tecknojock:master
Open

Changed Logs to Year-Month-Day#426
tecknojock wants to merge 1 commit into
WreckedAvent:masterfrom
tecknojock:master

Conversation

@tecknojock

Copy link
Copy Markdown

Year-month-day.txt makes a lot more sense from a logs standpoint than
month-day-year.txt as it is now. This allows logs to be naturally
sorted by sorting alphabetically and prevents the mixing of years as
time goes on.

Year-month-day.txt makes a lot more sense from a logs standpoint than
month-day-year.txt as it is now.  This allows logs to be naturally
sorted by sorting alphabetically and prevents the mixing of years as
time goes on.
@WreckedAvent

Copy link
Copy Markdown
Owner

This does make more sense (especially for non-Americans), but is no longer backwards compatible (which is why it wasn't done sooner). I can accept this PR if it's a setting somewhere which defaults to the old way.

@tecknojock

tecknojock commented May 13, 2017

Copy link
Copy Markdown
Author

How so? Slimcat grabs which log to used by most recently saved. I know this because I've had it happen a couple times where I've edited a log and it grabs that one. So it ought not to mess up the function of retrieving the present log.

@WreckedAvent

Copy link
Copy Markdown
Owner

I suppose backwards compatible is the wrong terminology. Some users of slimCat have been using it for years and have years of logs saved in the mm-dd-yyyy format. Just seems odd to change that without giving users an option to preserve the same format they've been using for years.

slimCat itself should work fine, as you noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants