Add a canary to imported symbols#40
Merged
Merged
Conversation
by importing a unique name in the split modules, we get a LinkError when these splits are imported from the incorrect main module (which would most likely lead to downstream problems such as mismatching function signatures). The canary is enabled only when the module is compiled with debug assertions enabled.
seems cache does not set executable bit correctly?
WorldSEnder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By importing a unique name in the split modules, we get a
LinkErrorwhen these splits are imported from the incorrect main module (which would most likely lead to downstream problems such as mismatching function signatures).The canary is enabled only when the module is compiled with debug assertions enabled.